[Bug 156] New: slf4j-ext OSGi bundle headers need updating for cal10n support

http://bugzilla.slf4j.org/show_bug.cgi?id=156

           Summary: slf4j-ext OSGi bundle headers need updating for cal10n
                    support
           Product: SLF4J
           Version: 1.5.x
          Platform: PC
        OS/Version: Mac OS X 10.3
            Status: NEW
          Severity: blocker
          Priority: P1
         Component: slf4j-ext
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Currently slf4j-ext exports

Export-Package: org.slf4j.profiler;version=1.5.9-RC0

which, with the adition of cal10n should be updated to include

org.slf4j.cal10n;version=XXX


--
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dev mailing list
[hidden email]
http://www.slf4j.org/mailman/listinfo/dev

http://bugzilla.slf4j.org/show_bug.cgi?id=156


Ceki Gulcu <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Ceki Gulcu <[hidden email]>  2009-10-28 18:55:00 ---
Fixed in [1]. Please verify by downloading a snapshot from github [1]. On [1],
click on the button labeled "Download" to download...

[1]
http://github.com/ceki/slf4j/commit/e967f5135e1bd2eb0d3165ec08cdb7a35bd1b200 


--
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dev mailing list
[hidden email]
http://www.slf4j.org/mailman/listinfo/dev

http://bugzilla.slf4j.org/show_bug.cgi?id=156





--- Comment #2 from Pete Muir <[hidden email]>  2009-10-29 13:34:00 ---
Created an attachment (id=62)
 --> (http://bugzilla.slf4j.org/attachment.cgi?id=62)
Fix exports, add import on cal10n, use property in POM

I believe that slf4j-ext should be importing ch.qos.cal10n and exporting
org.slf4j.cal10n.

Patch fixes this, and also uses ${cal10n.version} in the <dependencyManagement>
for slf4j in pursuit of DRY.


--
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dev mailing list
[hidden email]
http://www.slf4j.org/mailman/listinfo/dev

http://bugzilla.slf4j.org/show_bug.cgi?id=156


Pete Muir <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Attachment #62|Fix exports, add import on  |Add export on org.slf4j.ext
        description|cal10n, use property in POM |and org.slf4j.cal10n, remove
                   |                            |export on ch.qos.cal1on, add
                   |                            |import on ch.qos.cal10n, use
                   |                            |property in POM




--- Comment #3 from Pete Muir <[hidden email]>  2009-10-29 14:34:50 ---
(From update of attachment 62)
diff --git a/pom.xml b/pom.xml
index dff4a74..ae4a0e9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -82,7 +82,7 @@
     <dependency>
       <groupId>ch.qos.cal10n</groupId>
       <artifactId>cal10n-api</artifactId>
-      <version>0.7</version>
+      <version>${cal10n.version}</version>
     </dependency>

    </dependencies>
@@ -313,4 +313,4 @@

        </distributionManagement>

-</project>
\ No newline at end of file
+</project>
diff --git a/slf4j-ext/src/main/resources/META-INF/MANIFEST.MF
b/slf4j-ext/src/main/resources/META-INF/MANIFEST.MF
index 8760afa..2235ed7 100644
--- a/slf4j-ext/src/main/resources/META-INF/MANIFEST.MF
+++ b/slf4j-ext/src/main/resources/META-INF/MANIFEST.MF
@@ -4,5 +4,5 @@ Bundle-SymbolicName: slf4j.ext
 Bundle-Name: slf4j-log4j12
 Bundle-Vendor: SLF4J.ORG
 Bundle-RequiredExecutionEnvironment: J2SE-1.5
-Export-Package: org.slf4j.profiler;version=${project.version},
ch.qos.cal10n;version=${cal10n.version}
-Import-Package: org.slf4j;version=${project.version},
org.slf4j.spi;version=${project.version},
org.slf4j.helpers;version=${project.version}
+Export-Package: org.slf4j.profiler;version=${project.version},
org.slf4j.cal10n;version=${project.version},
org.slf4j.ext;version=${project.version}
+Import-Package: org.slf4j;version=${project.version},
org.slf4j.spi;version=${project.version},
org.slf4j.helpers;version=${project.version},
ch.qos.cal10n;version=${cal10n.version}


--
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dev mailing list
[hidden email]
http://www.slf4j.org/mailman/listinfo/dev

http://bugzilla.slf4j.org/show_bug.cgi?id=156





--- Comment #4 from Ceki Gulcu <[hidden email]>  2009-10-29 14:55:39 ---
Patch applied [1]. The export and import clauses now actually makes sense.
Sorry about the 0.7 version declaration instead of ${cal10n.version}.

[1]
http://github.com/ceki/slf4j/commit/43350ca4edfec8580aed98e997f4309b0bb137ac


--
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dev mailing list
[hidden email]
http://www.slf4j.org/mailman/listinfo/dev

http://bugzilla.slf4j.org/show_bug.cgi?id=156





--- Comment #5 from Pete Muir <[hidden email]>  2009-10-29 15:00:42 ---
The applied patch appears to be missing the export
"org.slf4j.ext;version=${project.version}" which allows people to use XLogger

Here is a patch.

diff --git a/slf4j-ext/src/main/resources/META-INF/MANIFEST.MF
b/slf4j-ext/src/main/resources/META-INF/MANIFEST.MF
index 0c1a1f0..2235ed7 100644
--- a/slf4j-ext/src/main/resources/META-INF/MANIFEST.MF
+++ b/slf4j-ext/src/main/resources/META-INF/MANIFEST.MF
@@ -4,5 +4,5 @@ Bundle-SymbolicName: slf4j.ext
 Bundle-Name: slf4j-log4j12
 Bundle-Vendor: SLF4J.ORG
 Bundle-RequiredExecutionEnvironment: J2SE-1.5
-Export-Package: org.slf4j.profiler;version=${project.version},
org.slf4j.cal10n;version=${project.version}
+Export-Package: org.slf4j.profiler;version=${project.version},
org.slf4j.cal10n;version=${project.version},
org.slf4j.ext;version=${project.version}
 Import-Package: org.slf4j;version=${project.version},
org.slf4j.spi;version=${project.version},
org.slf4j.helpers;version=${project.version},
ch.qos.cal10n;version=${cal10n.version}


--
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dev mailing list
[hidden email]
http://www.slf4j.org/mailman/listinfo/dev

http://bugzilla.slf4j.org/show_bug.cgi?id=156





--- Comment #6 from Ceki Gulcu <[hidden email]>  2009-10-29 15:10:58 ---
applied


--
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dev mailing list
[hidden email]
http://www.slf4j.org/mailman/listinfo/dev

http://bugzilla.slf4j.org/show_bug.cgi?id=156





--- Comment #7 from Ceki Gulcu <[hidden email]>  2009-10-29 15:15:55 ---
removed cruft. should be fine now:

http://git.qos.ch/gitweb/?p=slf4j.git;a=commit;h=58e6b11530ab61312326b4d5f4bf43900797d650


--
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dev mailing list
[hidden email]
http://www.slf4j.org/mailman/listinfo/dev

http://bugzilla.slf4j.org/show_bug.cgi?id=156





--- Comment #8 from Pete Muir <[hidden email]>  2009-10-29 19:21:57 ---
Roger Kitain has verified these fixes in GlassFish.


--
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dev mailing list
[hidden email]
http://www.slf4j.org/mailman/listinfo/dev

http://bugzilla.slf4j.org/show_bug.cgi?id=156





--- Comment #9 from Ceki Gulcu <[hidden email]>  2009-10-29 19:24:31 ---
Does this mean we are go for a public release of 1.5.9RC1 and cal10n 0.7.2?


--
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dev mailing list
[hidden email]
http://www.slf4j.org/mailman/listinfo/dev

http://bugzilla.slf4j.org/show_bug.cgi?id=156





--- Comment #10 from Pete Muir <[hidden email]>  2009-10-29 19:25:39 ---
Yes, we have verified slf4j 156 and 157 and CAL-8 and CAL-9 are all fixed.


--
Configure bugmail: http://bugzilla.slf4j.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dev mailing list
[hidden email]
http://www.slf4j.org/mailman/listinfo/dev